fix(web): consume plans on new-thread implementation#2
Open
UtkarshUsername wants to merge 1 commit intofix/consume-plan-on-same-thread-implementationfrom
Open
Conversation
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes pingdotgg#978
Stacked on top of pingdotgg#1133 (see https://pr-navigator.pages.dev/t3code-utkarsh).
What Changed
This extends plan consumption to the
Implement in new threadflow (pingdotgg#1133).PR 1 introduced the shared plan-consumption plumbing and applied it to same-thread
Implement. This PR wires the remaining caller: when the user choosesImplement in new thread, the new thread’sthread.turn.startcommand now includessourceProposedPlan.That allows the existing orchestration and runtime-ingestion path to mark the source proposed plan as implemented when the new thread’s implementation turn actually starts, so the original plan thread no longer remains actionable.
Why
Before this change, the same-thread implementation flow consumed the plan, but the new-thread implementation flow still started an implementation turn without identifying which source plan it came from.
That left the original thread in a stale actionable state even though the plan was already being implemented elsewhere.
This PR keeps the behavior consistent across both implementation entrypoints by reusing the same source-plan mechanism introduced in PR 1.
UI Changes
Combined the before/after videos and posted it on X because the files' sizes were too large to upload here: https://x.com/UtkarshUsername/status/2033161459447087223?s=20
Stack Context
This PR is stacked on top of:
fix/consume-plan-on-same-thread-implementationAfter PR 1 merges, this PR will be retargeted to
main.Checklist